Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add use remark sync hook #18

Merged
merged 9 commits into from
Jul 8, 2021
Merged

feat: add use remark sync hook #18

merged 9 commits into from
Jul 8, 2021

Conversation

ChristianMurphy
Copy link
Member

@ChristianMurphy ChristianMurphy commented Jan 21, 2021 •
edited
Loading

could close #16

TODO:

  • discuss
  • add documentation
  • add storybook stories
  • add tests
  • add synchronous component as well (?) (skipping for now)

@ChristianMurphy ChristianMurphy added 🗄 area/interface This affects the public interface 🛠 blocked/wip This cannot progress yet, it’s being worked on 🧒 semver/minor This is backwards-compatible change 💬 type/discussion This is a request for comments 🦋 type/enhancement This is great to have labels Jan 21, 2021
@wooorm
Copy link
Member

wooorm commented Jan 21, 2021

Seems like a good idea to me!

@agriffis
Copy link

This is what I'm looking for, too. Like @mattywong I have a custom CMS/server setup that needs to SSR customer-provided content.

@mattywong
Copy link

@ChristianMurphy any idea when this might get merged in? Would like to migrate out of our fork from this

@ChristianMurphy
Copy link
Member Author

Thanks for the reminder on this @mattywong!
This month, ideally this week, depending on how much time I have available.

@ChristianMurphy ChristianMurphy removed the 💬 type/discussion This is a request for comments label Jul 8, 2021
@ChristianMurphy ChristianMurphy requested a review from a team July 8, 2021 19:04
@ChristianMurphy ChristianMurphy removed the 🛠 blocked/wip This cannot progress yet, it’s being worked on label Jul 8, 2021
wooorm
wooorm reviewed Jul 8, 2021
View reviewed changes
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
@ChristianMurphy ChristianMurphy requested a review from wooorm July 8, 2021 19:23
@ChristianMurphy ChristianMurphy merged commit ac4cc63 into main Jul 8, 2021
@ChristianMurphy ChristianMurphy deleted the feat/sync-api branch July 8, 2021 19:29
@ChristianMurphy ChristianMurphy mentioned this pull request Jul 8, 2021
Closed
@karlhorky karlhorky mentioned this pull request Feb 18, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlhorky karlhorky karlhorky left review comments

@wooorm wooorm wooorm approved these changes

Assignees
No one assigned
Labels
🗄 area/interface This affects the public interface 🧒 semver/minor This is backwards-compatible change 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Server rendering/setting initial markdown state
5 participants
@ChristianMurphy @wooorm @agriffis @mattywong @karlhorky