-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remark-prepend-url to list of plugins #1375
Conversation
Signed-off-by: alxjpzmn <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1375 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 142 140 -2
=========================================
- Hits 142 140 -2 ☔ View full report in Codecov by Sentry. |
Welcome @alxjpzmn 👋 The types look a bit off, you may want to leverage The plugin will be passed a
Is the intent that you want to modify the source markdown to have the absolute URL? (if so a remark plugin is good) |
Thanks for the quick review @ChristianMurphy & the pointer re: the types :) Changed to
For my personal use case (generating a XML file) rehype would work, but I think being able to modify the source markdown is more versatile. For example, if I author a markdown file with relative links and the desired output is not only HTML but also a e.g. PDF, I'd first want the source markdown to uniformly contain absolute links. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This comment has been minimized.
This comment has been minimized.
Thank you! |
Initial checklist
Description of changes
Add remark-prepend-url to the plugin list.