feat: add `samlify` example #130

christopherpickering · 2023-01-16T19:47:10Z

No description provided.

MichaelDeBoey

Please create an as small as possible example.

This means you should start from the remix template & add only the really necessary things.

We don't want to make these examples too complicated/bloated.

christopherpickering · 2023-01-16T20:24:03Z

hmm I started with the blues stack and added a few files. Should I start with a different one, or did I change it too much? Thanks!

MichaelDeBoey · 2023-01-16T21:22:46Z

@christopherpickering Best is to start with the __template folder of this repo as a basis and add only the bare minimum to get your example working

christopherpickering · 2023-01-20T16:25:00Z

@MichaelDeBoey how's it looking now? You can squash when you merge?

Thanks!

machour

Can we renamed the folder to "auth-saml-ldap" ? remix is implicit in this repo 😅
(don't forget to update the sandbox link)

Also, is the git ubmodule saml-idp really needed here?

oups

christopherpickering · 2023-01-20T16:56:30Z

Cool, I'll rename. Yeah, the submodule is used for the dev to show the example SAML login.

christopherpickering · 2023-01-20T17:10:17Z

Sorry that was a messy name change, but should be good now.

MichaelDeBoey

Please also fix all ESLint errors/warnings

CC/ @machour @mcansh What would you think of renaming this to saml-ldap-auth instead?

MichaelDeBoey · 2023-01-22T02:43:27Z

auth-saml-ldap/README.md

+<!-- TODO: update this link to the path for your example: -->
+


This comment should be deleted

Suggested change

Ping @christopherpickering

auth-saml-ldap/README.md

auth-saml-ldap/app/root.tsx

auth-saml-ldap/app/routes/auth/asc.tsx

auth-saml-ldap/app/routes/auth/slo.tsx

christopherpickering · 2023-01-23T16:03:57Z

Thanks, I removed the submodule (now cloning the idp instead) and updated the lint.

auth-saml-ldap/app/root.tsx

auth-saml-ldap/app/routes/index.tsx

auth-saml-ldap/app/routes/login.tsx

auth-saml-ldap/app/routes/auth/asc.tsx

auth-saml-ldap/app/routes/login.tsx

auth-saml-ldap/app/routes/logout.tsx

Co-authored-by: Michaël De Boey <[email protected]>

christopherpickering · 2023-01-23T21:01:54Z

@MichaelDeBoey thanks bro, wish I coulda been a programmer like you 😀 unfortunately, some of us never get out of kindergarten

christopherpickering · 2023-01-23T21:02:29Z

shucks didn't mean to close it.

MichaelDeBoey · 2023-01-23T22:06:11Z

unfortunately, some of us never get out of kindergarten

@christopherpickering No need to make these kind of comments imo
I'm just trying to make sure your code adheres to the standards we use in our code/this repo, that's all 🤷‍♂️

So if you feel offended by them: I'm sorry, 'cause that's not what I'm trying to do at all.

MichaelDeBoey

Please also run ESLint on the files

auth-saml-ldap/app/root.tsx

auth-saml-ldap/app/routes/auth/slo.tsx

auth-saml-ldap/app/routes/auth/asc.tsx

auth-saml-ldap/app/models/user.server.ts

MichaelDeBoey · 2023-01-23T22:24:30Z

auth-saml-ldap/app/models/user.server.ts

@@ -0,0 +1,86 @@
+import type { User } from "@prisma/client";


Suggested change

import type { User } from "@prisma/client";

import type { Group, User } from "@prisma/client";

Ping @christopherpickering

auth-saml-ldap/app/models/user.server.ts

christopherpickering · 2023-01-23T23:06:08Z

unfortunately, some of us never get out of kindergarten

@christopherpickering No need to make these kind of comments imo I'm just trying to make sure your code adheres to the standards we use in our code/this repo, that's all 🤷‍♂️

So if you feel offended by them: I'm sorry, 'cause that's not what I'm trying to do at all.

😁 I'm not offended, just jealous that I didn't see all that stuff you recommended when I went through it :) Wishing you could review all my code!

MichaelDeBoey · 2023-01-23T23:12:52Z

I'm not offended

Oh OK, then I misunderstood your comment 🙈

auth-saml-ldap/app/ldap.server.tsx

auth-saml-ldap/app/models/user.server.ts

auth-saml-ldap/app/routes/auth/slo.tsx

auth-saml-ldap/app/session.server.ts

auth-saml-ldap/app/ldap.server.tsx

christopherpickering · 2023-01-25T14:17:27Z

@MichaelDeBoey thanks, is there another linter you run to find more ways to improve the code, or have a better set of es rules than the default? Or have a style guide I can check out? I'm wondering how I can improve my code from the beginning. Thanks!

christopherpickering · 2023-02-14T17:30:05Z

@MichaelDeBoey I think I've gotten everything taken care of 👍🏽

MichaelDeBoey · 2023-03-06T20:41:25Z

auth-saml-ldap/app/entry.client.tsx

@@ -0,0 +1,21 @@
+import { RemixBrowser } from "@remix-run/react";


Let's remove this file (see #159)

MichaelDeBoey · 2023-03-06T20:41:37Z

auth-saml-ldap/app/entry.server.tsx

@@ -0,0 +1,110 @@
+import { PassThrough } from "stream";


Same (see #159)

MichaelDeBoey · 2023-03-06T20:43:41Z

auth-saml-ldap/app/routes/auth/slo.tsx

+/* can't do idp initiated logout w/ cookie sessions, but can still use
+   this point to logout if we wanna
+*/
+export const action = async (request: Request) => {


Suggested change

export const action = async (request: Request) => {

export const action = async ({ request }: ActionArgs) => {

MichaelDeBoey · 2023-03-06T20:43:57Z

auth-saml-ldap/app/routes/auth/slo.tsx

@@ -0,0 +1,8 @@
+import { logout } from "~/session.server";


Suggested change

import { logout } from "~/session.server";

import type { ActionArgs } from "@remix-run/node";

import { logout } from "~/session.server";

MichaelDeBoey · 2023-03-06T20:46:37Z

auth-saml-ldap/package.json

+    "saml:cert": "openssl req -x509 -new -newkey rsa:2048 -nodes -subj '/C=US/ST=California/L=San Francisco/O=JankyCo/CN=Test Identity Provider' -keyout test/saml-idp/idp-private-key.pem -out test/saml-idp/idp-public-cert.pem -days 7300",
+    "saml:setup": "rm -rf test/saml-idp; mkdir test/saml-idp; git clone https://github.com/mcguinness/saml-idp.git test/saml-idp; cd test/saml-idp/; npm install",
+    "start": "remix-serve build",
+    "setup": "prisma generate && prisma migrate dev --name \"initial\""


Let's add typecheck script to be in line with all other examples (see #98)

Suggested change

"setup": "prisma generate && prisma migrate dev --name \"initial\""

"setup": "prisma generate && prisma migrate dev --name \"initial\"",

"typecheck": "tsc"

MichaelDeBoey · 2023-06-06T21:41:29Z

Hi @christopherpickering!

Are you still interested in getting this one merged?

If so, please rebase onto latest main & implement remarks

christopherpickering · 2023-06-06T23:38:01Z

@MichaelDeBoey I ended up writing an auth strategy for remix-auth. This pr can probably be closed unless you would like it added.

added remix saml auth example

ec66b30

MichaelDeBoey changed the title ~~added remix saml auth example~~ feat: add samlify example Jan 16, 2023

MichaelDeBoey requested changes Jan 16, 2023

View reviewed changes

simplified example

14bfa7a

removed migrations folder so initial setup will work

759c30a

machour previously approved these changes Jan 20, 2023

View reviewed changes

christopherpickering added 2 commits January 20, 2023 11:02

renamed

2a179ea

fixed submodule

a2e3d29

christopherpickering force-pushed the main branch from d4290ac to a2e3d29 Compare January 20, 2023 17:07

removed old files

6c04bb1

MichaelDeBoey requested changes Jan 22, 2023

View reviewed changes

passed lint, removed git submodule

9958b81

removed unused line

58d3757

MichaelDeBoey requested changes Jan 23, 2023

View reviewed changes

christopherpickering and others added 9 commits January 23, 2023 14:55

Update auth-saml-ldap/app/root.tsx

6f34075

Co-authored-by: Michaël De Boey <[email protected]>

Update auth-saml-ldap/app/routes/logout.tsx

bba6ac2

Co-authored-by: Michaël De Boey <[email protected]>

Update auth-saml-ldap/app/routes/login.tsx

cc69f3c

Co-authored-by: Michaël De Boey <[email protected]>

Update auth-saml-ldap/app/routes/login.tsx

c85a62a

Co-authored-by: Michaël De Boey <[email protected]>

Update auth-saml-ldap/app/routes/login.tsx

91e297c

Co-authored-by: Michaël De Boey <[email protected]>

Update auth-saml-ldap/app/routes/login.tsx

e2736e4

Co-authored-by: Michaël De Boey <[email protected]>

Update auth-saml-ldap/app/routes/login.tsx

bdcf116

Co-authored-by: Michaël De Boey <[email protected]>

Update auth-saml-ldap/app/routes/index.tsx

0e9eb14

Co-authored-by: Michaël De Boey <[email protected]>

Update auth-saml-ldap/app/ldap.server.tsx

53fd18f

Co-authored-by: Michaël De Boey <[email protected]>

christopherpickering and others added 9 commits January 23, 2023 14:58

Update auth-saml-ldap/app/routes/auth/asc.tsx

7d49ff8

Co-authored-by: Michaël De Boey <[email protected]>

Update auth-saml-ldap/app/routes/auth/asc.tsx

221f387

Co-authored-by: Michaël De Boey <[email protected]>

Update auth-saml-ldap/app/models/user.server.ts

843192b

Co-authored-by: Michaël De Boey <[email protected]>

Update auth-saml-ldap/app/models/user.server.ts

af4e4e4

Co-authored-by: Michaël De Boey <[email protected]>

Update auth-saml-ldap/app/models/user.server.ts

17d444e

Co-authored-by: Michaël De Boey <[email protected]>

Update auth-saml-ldap/app/models/user.server.ts

1a4efbe

Co-authored-by: Michaël De Boey <[email protected]>

Update auth-saml-ldap/app/routes/auth/asc.tsx

84f4563

Co-authored-by: Michaël De Boey <[email protected]>

Update auth-saml-ldap/app/routes/auth/asc.tsx

bdcbc69

Co-authored-by: Michaël De Boey <[email protected]>

Update auth-saml-ldap/app/routes/auth/asc.tsx

d961132

Co-authored-by: Michaël De Boey <[email protected]>

christopherpickering closed this Jan 23, 2023

christopherpickering reopened this Jan 23, 2023

MichaelDeBoey requested changes Jan 23, 2023

View reviewed changes

updated recommendations and lint

35ba527

christopherpickering requested a review from MichaelDeBoey January 24, 2023 14:38

MichaelDeBoey requested changes Jan 25, 2023

View reviewed changes

removed uneeded await

9c7e172

christopherpickering requested a review from MichaelDeBoey January 25, 2023 14:16

MichaelDeBoey requested changes Mar 6, 2023

View reviewed changes

MichaelDeBoey added the needs-response We need a response from the original author about this issue/PR label Jun 6, 2023

github-actions bot removed the needs-response We need a response from the original author about this issue/PR label Jun 7, 2023

MichaelDeBoey closed this Jun 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add `samlify` example #130

feat: add `samlify` example #130

christopherpickering commented Jan 16, 2023

MichaelDeBoey left a comment

christopherpickering commented Jan 16, 2023

MichaelDeBoey commented Jan 16, 2023

christopherpickering commented Jan 20, 2023

machour left a comment

christopherpickering commented Jan 20, 2023

christopherpickering commented Jan 20, 2023

MichaelDeBoey left a comment

MichaelDeBoey Jan 22, 2023 •

edited

Loading

MichaelDeBoey Mar 6, 2023

christopherpickering commented Jan 23, 2023

christopherpickering commented Jan 23, 2023 •

edited

Loading

christopherpickering commented Jan 23, 2023

MichaelDeBoey commented Jan 23, 2023

MichaelDeBoey left a comment

MichaelDeBoey Jan 23, 2023

MichaelDeBoey Mar 6, 2023

christopherpickering commented Jan 23, 2023

MichaelDeBoey commented Jan 23, 2023

christopherpickering commented Jan 25, 2023

christopherpickering commented Feb 14, 2023

MichaelDeBoey Mar 6, 2023

MichaelDeBoey Mar 6, 2023

MichaelDeBoey Mar 6, 2023

MichaelDeBoey Mar 6, 2023

MichaelDeBoey Mar 6, 2023

MichaelDeBoey commented Jun 6, 2023

christopherpickering commented Jun 6, 2023

		<!-- TODO: update this link to the path for your example: -->

	import type { User } from "@prisma/client";
	import type { Group, User } from "@prisma/client";

		@@ -0,0 +1,21 @@
		import { RemixBrowser } from "@remix-run/react";

	export const action = async (request: Request) => {
	export const action = async ({ request }: ActionArgs) => {

	import { logout } from "~/session.server";
	import type { ActionArgs } from "@remix-run/node";
	import { logout } from "~/session.server";

	"setup": "prisma generate && prisma migrate dev --name \"initial\""
	"setup": "prisma generate && prisma migrate dev --name \"initial\"",
	"typecheck": "tsc"

feat: add samlify example #130

feat: add samlify example #130

Conversation

christopherpickering commented Jan 16, 2023

MichaelDeBoey left a comment

Choose a reason for hiding this comment

christopherpickering commented Jan 16, 2023

MichaelDeBoey commented Jan 16, 2023

christopherpickering commented Jan 20, 2023

machour left a comment

Choose a reason for hiding this comment

christopherpickering commented Jan 20, 2023

christopherpickering commented Jan 20, 2023

MichaelDeBoey left a comment

Choose a reason for hiding this comment

MichaelDeBoey Jan 22, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

christopherpickering commented Jan 23, 2023

christopherpickering commented Jan 23, 2023 • edited Loading

christopherpickering commented Jan 23, 2023

MichaelDeBoey commented Jan 23, 2023

MichaelDeBoey left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

christopherpickering commented Jan 23, 2023

MichaelDeBoey commented Jan 23, 2023

christopherpickering commented Jan 25, 2023

christopherpickering commented Feb 14, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MichaelDeBoey commented Jun 6, 2023

christopherpickering commented Jun 6, 2023

feat: add `samlify` example #130

feat: add `samlify` example #130

MichaelDeBoey Jan 22, 2023 •

edited

Loading

christopherpickering commented Jan 23, 2023 •

edited

Loading