Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to Jest v29 #9253

Closed
wants to merge 23 commits into from
Closed

chore: update to Jest v29 #9253

wants to merge 23 commits into from

Conversation

SimenB
Copy link

@SimenB SimenB commented Sep 14, 2022

👋

I noticed you were on an old version when looking through the code, so I thought to update it.

Main changes are:

@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2022

⚠️ No Changeset found

Latest commit: af34fb4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Sep 14, 2022

Hi @SimenB,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Sep 14, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@mattrigg9
Copy link

Hey team, any update on getting this merged? Jest 28+ doesn't appear to be compatible with Remix packages without addressing the package import issue mentioned above. Thanks!

@timdorr
Copy link
Member

timdorr commented Jan 12, 2023

I fixed the conflicts, but it looks like there's been enough updates since this PR to require more changes. Let me look into it...

@bgaleotti
Copy link

@timdorr seems like snapshots are different since Jest 29 https://jestjs.io/blog/2022/08/25/jest-29 and need to be updated.

@timdorr timdorr changed the base branch from main to dev January 12, 2023 17:57
@timdorr
Copy link
Member

timdorr commented Jan 12, 2023

OK, now for the fun part: This was based on main, not the dev branch (which should be ahead code-wise and is where this should target). I got it fixed on main, so hopefully this is just resolving those conflicts. Fun! :S

@timdorr
Copy link
Member

timdorr commented Jan 12, 2023

Switching to #9895 because I can't push to this remote branch anymore. Not Simen's fault, just a GitHub thing.

@timdorr timdorr closed this Jan 12, 2023
@SimenB SimenB deleted the update-jest branch January 13, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.