Fix homepage text overlap on certain screen sizes #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brophdawg11
approved these changes
Aug 9, 2024
|
Thanks @brophdawg11 for reviewing! I'll merge on Monday to avoid someone noticing an regression/new visual bug over the weekend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #286
Test the fix on the staging site
As pointed out in the issue, on certain screen resolutions we have some text overlap. I had to crank my resolution down to 1504 x 846 and adjust the height of the window a bit to replicate the experience
a-fix.mov
From what I can tell, switching a few
heights tomin-heights seems to fix it without affecting the experience for any other sites.Would love additional spot checks before merging