Skip to content

Commit

Permalink
add engines to package.json and set engines-strict=true (#486)
Browse files Browse the repository at this point in the history
Co-authored-by: Kent C. Dodds <[email protected]>
  • Loading branch information
UsamaHameed and kentcdodds authored Dec 3, 2021
1 parent 541e27c commit d4e6168
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 0 deletions.
1 change: 1 addition & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
engine-strict=true
1 change: 1 addition & 0 deletions contributors.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
- msutkowski
- nareshbhatia
- ryanflorence
- UsamaHameed
- luispagarcia
- silvenon
- stephanerangaya
Expand Down
2 changes: 2 additions & 0 deletions docs/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ If you'd like to contribute something—whether it's a bug fix to scratch your o

**We don't yet have a CLA, but we are working on it and we will be able to accept your contributions as soon as we do.** Until then, please keep letting us know about our bugs and typos in Discord and we will do our best to address them.

When you start a pull request, the remix-cla-bot will prompt you to review the [CLA](https://github.com/remix-run/remix/blob/main/docs/contributing.md) and sign it by adding your name to `contributors.yml`.

## Setup

Before you can contribute to the codebase, you will need to fork the repo. This will look a bit different depending on what type of contribution you are making:
Expand Down
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,9 @@
"typescript": "^4.2.3",
"unified": "^9.2.0"
},
"engines": {
"node": ">=14"
},
"lint-staged": {
"*.{js,jsx,ts,tsx}": [
"eslint --cache --fix",
Expand Down

0 comments on commit d4e6168

Please sign in to comment.