Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override cookie encode #10055

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Override cookie encode #10055

wants to merge 3 commits into from

Commits on Oct 3, 2024

  1. fix: don't Base64 encode cookie if encode is set 

    Right now, if a developer adds an encode/decode function when creating a cookie, it's applied after the cookie is Base64 encoded. We should not Base64 encode a cookie if the developer have added a `encode`/`decode` override to the
cookie options. Unfortunately this makes the override and sign/secret options mutually exclusive.

BREAKING CHANGE: If you override the cookie encode/decode functions, you can't sign the cookie with a secret
    @Evanion
    Evanion committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    831bb63 View commit details
    Browse the repository at this point in the history

  2. test: add tests for encode/decode overrrides 

    adds tests for the encode/decode options.
    @Evanion
    Evanion committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    455a148 View commit details
    Browse the repository at this point in the history

  3. chore: sign CLA

    @Evanion
    Evanion committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    d307d8b View commit details
    Browse the repository at this point in the history