Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update single fetch deprecation notice to also include info about null #10145

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

JakeGinnivan
Copy link
Contributor

Resource routes can no longer just return null, call this out in the deprecation notice.

It just took me a minute to realise it was the null which was triggering the message.

Copy link

changeset-bot bot commented Oct 21, 2024

⚠️ No Changeset found

Latest commit: 846785e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JakeGinnivan
Copy link
Contributor Author

I'll update the tests if this is actually correct. Let me know.

@brophdawg11 brophdawg11 changed the base branch from main to dev October 21, 2024 17:19
@brophdawg11 brophdawg11 changed the base branch from dev to main October 21, 2024 17:20
@brophdawg11
Copy link
Contributor

Thanks @JakeGinnivan! I made a minor update to elaborate on it also being specific to "externally accessed" resource routes. Would you mind rebasing this and pointing to dev since it's a source code change and we can get it merged for the next release?

JakeGinnivan and others added 3 commits October 22, 2024 07:23
Resource routes can no longer just return null, call this out in the deprecation notice.
@JakeGinnivan
Copy link
Contributor Author

Done @brophdawg11. Thanks

Let me know if I need to squash/apply conventional commits. This started as a bit of a drive by, haha

@brophdawg11
Copy link
Contributor

Looks good! No need to change any commits - I'll squash-merge the PR.

Would you mind adding a changeset as well? Should be able to just type pnpm changeset and follow the prompts for a patch change for the server-runtime package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants