-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update single fetch deprecation notice to also include info about null #10145
base: dev
Are you sure you want to change the base?
Conversation
|
I'll update the tests if this is actually correct. Let me know. |
Thanks @JakeGinnivan! I made a minor update to elaborate on it also being specific to "externally accessed" resource routes. Would you mind rebasing this and pointing to |
Resource routes can no longer just return null, call this out in the deprecation notice.
Done @brophdawg11. Thanks Let me know if I need to squash/apply conventional commits. This started as a bit of a drive by, haha |
Looks good! No need to change any commits - I'll squash-merge the PR. Would you mind adding a changeset as well? Should be able to just type |
Resource routes can no longer just return null, call this out in the deprecation notice.
It just took me a minute to realise it was the null which was triggering the message.