-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support Vite 6 HMR #10255
base: dev
Are you sure you want to change the base?
feat: support Vite 6 HMR #10255
Conversation
🦋 Changeset detectedLatest commit: 92a7fd2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hi @sapphi-red, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Same as #10254, could you point this at the dev
branch and add a changeset?
I did the same with #10254 🙂 |
In Vite v5 and below, Vite mixed the client modules and the SSR modules in a single module graph. This caused a unnecessary HMR when a file that only affects a single environment (e.g. editing a SSR only module triggered a HMR on the client side unconditionally).
In Vite v6, the module graphs are separated for each environment to give a way to remove that unnecessary HMR. But that means the frameworks now have to trigger HMR on their own when a module in a different environment is changed.
This PR implements that HMR triggering logic. It triggers the client HMR when the SSR module is changed like it was working in Vite 5. This code triggers unnecessary HMR as same as Vite v5, but at least makes remix work with Vite 6. I think that can be improved in a separate PR.
Testing Strategy: I ran
pnpm i && pnpm vite-ecosystem-ci:build && pnpm vite-ecosystem-ci:test
with both Vite 5.x and 6.x.