Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: demote browser export #11

Closed
wants to merge 2 commits into from
Closed

fix: demote browser export #11

wants to merge 2 commits into from

Commits on Jun 6, 2022

  1. Prefer require, import and types exports over browser 

    Exports are resolved in order, i.e. the first match is used.

I'm not sure why the browser export is using the raw src, however this causes issues with Jest when configured with jsdom, as it will resolve to this file and not be able to transpile it. Jest also throws a type error as discussed on remix-run/remix#3402
    @penx
    penx committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    2f9ecb9 View commit details
    Browse the repository at this point in the history

  2. Prefer types exports over require, import, browser

    @penx
    penx committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    9105002 View commit details
    Browse the repository at this point in the history