feat(next): group-array field support #177
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… group arrays don't work yet
sandrina-p
reviewed
May 7, 2025
next/src/field/array.ts
Outdated
| } | ||
|
|
||
| if (schema.description !== undefined) { | ||
| field.description = schema.description |
There was a problem hiding this comment.
bug: We should spread all schema keys (except items) down to field, why did you decide to not do it?
For example, if I pass x-foo, it will be ignored by JSF.
There was a problem hiding this comment.
Good catch, that was not intentional. I've just pushed a change that reuses the same logic for propagating schema props to fields while excluding certain keywords.
lukad
changed the title
This also simplifies field generation a bit by removing the object special case as well as the array special case which
lukad
force-pushed
the
devxp-2540-group-array-fields
branch
from
41d63be to
541f8ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for generating fields for
{"type":"array"}schemas which includes:itemssubschema is anobjectschema)itemssubschema is anything else e.g.{"type": "array", "items": {"type": "string}}