feat(next): Create x-jsf-ui alias to x-jsf-presentation
#190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandrina-p
commented
May 21, 2025
| const { minDate, maxDate } = schema['x-jsf-presentation'] | ||
| // TODO: Why do we need to cast to JsfPresentation, | ||
| // even though we know it's not undefined (from the if above)? | ||
| const { minDate, maxDate } = getUiPresentation(schema) as JsfPresentation |
There was a problem hiding this comment.
help: tell me there's a better way :x
sandrina-p
commented
May 21, 2025
| @@ -10,13 +10,13 @@ export function getErrorMessage( | |||
| validation: SchemaValidationErrorType, | |||
| customErrorMessage?: string, | |||
| ): string { | |||
| const presentation = schema['x-jsf-presentation'] | |||
| const presentation = getUiPresentation(schema) | |||
There was a problem hiding this comment.
@lukad @dragidavid @antoniocapelo @eng-almeida from now on, let's remember to use this helper rather than typing directly x-jsf-presentation. I wish we had a linter against it... maybe one day ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create
x-jsf-uialias tox-jsf-presentation.Why? Because it's easier/faster to write :D