Lean: ignore unused variables and increase compute outs #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasgrosser
force-pushed
the
lean-disable-warnings
branch
from
c7a85da to
037fa78
Compare
ineol
reviewed
Feb 15, 2025
This reduces the number of warnings+errors from 3021 to 1562 on the RISC-V spec. This closes rems-project#1011. Co-authored-by: Léo Stefanesco <[email protected]>
tobiasgrosser
force-pushed
the
lean-disable-warnings
branch
from
875c33d to
1328b4e
Compare
tobiasgrosser
changed the title
tobiasgrosser
changed the title
|
Thank you, @ineol. Following your advice, I added support for compute-outs as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the number of warnings and errors from 3021 to 1547 on the RISC-V spec.
Thank you to @ineol for suggesting this improvement.
This closes #1011.