Lean: improve handling of arguments #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ineol
force-pushed
the
lean-better-args
branch
from
0dd2f39 to
baa8132
Compare
ineol
force-pushed
the
lean-better-args
branch
from
baa8132 to
3f2424b
Compare
ineol
force-pushed
the
lean-better-args
branch
2 times, most recently
from
9b4a108 to
6758c41
Compare
|
Nice. This resolves 158 errors. |
tobiasgrosser
approved these changes
Feb 15, 2025
1. We handle irrefutable patterns in argument positions by adding an equivalent let in the prelude of the function. 2. We handle `atom` types deep inside the type of the arguments. We translate the pattern in the argument as above as a variable, and we replace the sail type variable by `tuple.2.1` in the return type. This path and the variable bound in the let binding in the prelude are definitionally equal. 3. As a side fix, we use more unique names for the autogenerated variable names by numbering them, which should avoid some spurious shadowing.
ineol
force-pushed
the
lean-better-args
branch
from
6758c41 to
b86ea3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
atomtypes deep inside the type of the arguments. We translate the pattern in the argument as above as a variable, and we replace the sail type variable bytuple.2.1in the return type. This path and the variable bound in the let binding in the prelude are definitionally equal.