Lean: put the generated functions in a namepace #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ineol
force-pushed
the
lean-namespace
branch
from
bd6745f to
7957ef0
Compare
ineol
changed the title
|
Nice. I guess this just needs an update of the formatter. |
This partially addresses the fact that Sail has a different namespace for types and terms, and as such some models have types with the same names as terms.
ineol
force-pushed
the
lean-namespace
branch
from
7957ef0 to
6135af6
Compare
Actually the issue is that I have forgotten to update an expected file. I don't know why it was the check formatting test that failed... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially addresses the fact that Sail has a different namespace for types and terms, and as such some models have types with the same names as terms.