Move global signal declaration from toplevel to the sail_toplevel module #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, a rewrite pass in the AST distinguishes global from local signals by splitting E_id nodes into E_id or E_gid for local or global references. Then the SV generation changes as follows : - All signal declaration at toplevel (i.e. no parent module) are removed - These signals are all added as 'sail_toplevel' internal signals instead - All references to globals are prepended with the SAIL_GLOBALS macro This prevents unresolved signal paths in EDA tools, since now all existing signals are declared in a module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a v2 of the former pull request : #886
Since I restarted from a new branch, I figured it would be more adequate to open a new PR.
The approach used in the v2 is :
E_gidfor ASTAV_gidfor ANFV_idfor JIBGlobal_var(in addition toVar) for the SMT expressionE_idglobal references intoE_gid.prepend_globalsoptional argument from the pretty-printer functionsspec_info.global_letswith thectypto declare the globals inmodule sail_toplevel(thus removing the global state introduced in the v1 of the PR).