Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check for broken fpm-status page #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blodan
Copy link

@blodan blodan commented Jul 13, 2021

Context

This fix catches all different versions of output that can happen for a non-existing fpm status page.

For example for the php-fpm 7.4 alpine image only "Primary script unknown" is returned. Not sure if this is due to different php versions or if it's always been this way.

I've also noticed that Kubernetes readiness + liveness probes does not catch the output when sent to stderr so you might want to consider removing >&2 from error messages. We are running without them internally and that works great with Kubernetes.

Changes

  • Tests included
  • Documentation updated
  • Commit message is clear

@wandersonwhcr
Copy link
Collaborator

Hello @blodan, sorry for the delay.

Do you have any idea how can we implement TDD in this case?

@wandersonwhcr wandersonwhcr added this to the v0.6.0 milestone Dec 23, 2021
@wandersonwhcr wandersonwhcr added the bug Something isn't working label Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants