Change assert to warning in visuz.py #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When any of significantly enriched genes, significantly depleted genes, or non-significant genes are missing, current implementation in visuz.py will throw an error. However sometimes they could be missing. This is not biologically prohibited, and the code could handle this situation without problem. So compared to an assertion, throwing out warning is more appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When any of significantly enriched genes, significantly depleted genes, or non-significant genes are missing, current implementation in visuz.py will throw an error.
However sometimes they could be missing. This is not biologically prohibited, and the code could handle this situation without problem.
So compared to an assertion, throwing out warning is more appropriate.