Typefaces are now cached #221
Conversation
| private static final Hashtable<String, Typeface> FONT_CACHE = new Hashtable<>(); | ||
|
|
||
| public static Typeface get(String name, AssetManager assets) { | ||
| synchronized (FONT_CACHE) { |
There was a problem hiding this comment.
Hashtable is already synchronised. Does it need to be sync? the get typeface is executed on the UI thread.. and anyway I would use a weakreference to the typeface..
There was a problem hiding this comment.
You`re right in case of synchronization. But I'm quite skeptical about weak references to typefaces. In situation you're moving from one activity to another, the fonts will be (probably/maybe) garbage collected and loaded again. It is expected the font will be changed in whole application if it's changed in EditTexts. After all, It's not a big deal.
There was a problem hiding this comment.
yes, you are right about the weakreference but I would prefer to reload it than having it in memory if not used.
There was a problem hiding this comment.
Sure, lets continue in pull-request #252.
Critically improves layout loading speed when multiple instances of MaterialEditText with custom typefaces is used.