Add support for LPC USART TX IDLE IRQ + TX IDLE status flag #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laurens Miers <[email protected]>
Store the TXIDLE interrupt status and check if we need to generate an interrupt in UpdateInterrupts(). We generate an interrupt if both conditions are true: - The TXIDLE interrupt is enabled - AND the TX queue is empty This is part 1/2 of enabling the non-blocking API in the standard LPC SDK fsl_usart.c driver. Next we need to implement the TXIDLE status flag. Signed-off-by: Laurens Miers <[email protected]>
The TXIDLE register-flag is a status flag indicating if the USART TX is idle/done. This means whenever the queue is empty, we should report idle. This is part 2/2 of enabling the non-blocking API in the standard LPC SDK fsl_usart.c driver. Signed-off-by: Laurens Miers <[email protected]>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the LPC USART TX IDLE IRQ and TX IDLE status flag which enables the support for the USART non-blocking API which is part of the standard LPC SDK.
More info is available in the raised github issue:
renode/renode#761
Reproduction using the renode-template
It is based on the lpcxpresso55s16 board which is running some zephyr examples using renode:
https://designer.antmicro.com/hardware/devices/lpcxpresso55s16?software=zephyr|lpcxpresso55s16|
the repo has a binary compiled from the LPC SDK for the usart_interrupt_transfer driver example.
It's basically a echo-example using the non-blocking usart API. Whatever we write to the uart, should be printed back to us.
Failing
A failing example with the current LPC_USART C# peripheral can be found here:
https://github.com/laurensmiers/renode-issue-reproduction-template/tree/761-lpc-usart-txidle-irq-not-firing
Passing
The passing example uses the updated LPC_USART driver of this PR (copied into the other repo and dynamically included):
https://github.com/laurensmiers/renode-issue-reproduction-template/tree/761-lpc-usart-txidle-irq
If more info or changes are required, let me know.