Fix regression tests #373
Open
Fix regression tests #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbonne
commented
Nov 23, 2023
dbonne
commented
- Removed regression tests for postgres 10 and 11
- Fixed regression tests
* `allow_in_place_tablespaces` is used to fix running regression tests locally Signed-off-by: Daymel Bonne Solís <[email protected]>
dbonne
force-pushed
the
fix_regression_tests
branch
from
a7e3bd2 to
fa132db
Compare
| @@ -12,14 +12,11 @@ jobs: | |||
| - 14 | |||
| - 13 | |||
| - 12 | |||
| - 11 | |||
| - 10 | |||
There was a problem hiding this comment.
Is there a reason to remove the tests? Yes, PostgreSQL version 10 and 11 is no longer supported, but it will be nice to know if and when pg_repack fails on these versions.
|
What exactly is fixed in the regression tests? |
|
It is not really a fix, but IMO an improvement, because it removes the need to create a tablespace outside of regression tests by utilizing But, I agree, there is no reason not to run tests on 10 and 11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.