Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/ethers5 #129

Merged
merged 10 commits into from
Jan 29, 2024
Merged

feat/ethers5 #129

merged 10 commits into from
Jan 29, 2024

Conversation

ignaciosantise
Copy link
Collaborator

Summary

  • Added new ethers5 package
  • Added new coinbase connector for ethers package
  • Renamed coinbase-react-native to coinbase-wagmi-react-native

Copy link
Contributor

github-actions bot commented Jan 29, 2024

Qodana for JS

9 new problems were found

Inspection name Severity Problems
Result of method call returning a promise is ignored ◽️ Notice 6
Field can be readonly ◽️ Notice 3
@@ Code coverage @@
- 45% total lines covered
382 lines analyzed, 174 lines covered
! 0% fresh lines covered
1 lines analyzed, 0 lines covered
# Calculated according to the filters of your coverage tool

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Copy link
Contributor

github-actions bot commented Jan 29, 2024

🚀 Expo preview is ready!

  • Project → web3modal-sdk
  • Platforms → android, ios
  • Runtime Version → 1.0.0
  • More info

Learn more about 𝝠 Expo Github Action

@ignaciosantise ignaciosantise merged commit 0bdf56e into main Jan 29, 2024
4 checks passed
@ignaciosantise ignaciosantise deleted the feat/ethers5 branch January 29, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant