added filter transactions by chain #1834
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Looks like build is failing, so only leaving comments for now. As we are filtering data client side, will need to see how this affects pagination logic (we likely display less results than what we fetched).
Any chance this chain filtering can be done on blockchain api level vs on client?
…onent update call
| filterByConnectedChain(transactions: Transaction[]) { | ||
| const chainId = NetworkController.state.caipNetwork?.id | ||
| const filteredTransactions = transactions.filter( | ||
| transaction => transaction.metadata.chain === chainId | ||
| ) | ||
|
|
||
| return filteredTransactions | ||
| }, |
There was a problem hiding this comment.
I thought we were requesting the filtered txs directly from blockchain api 🤔
wouldn't this mess up with pagination?
There was a problem hiding this comment.
wouldn't this mess up with pagination?
Mmm I'm not sure and I'm not able to test this 🤔
There was a problem hiding this comment.
@geekbrother any way we can do the filterin directly on blockchain API side? I think there's an edge case to this where if we filter txs and don't have enough to fill the ui, we will never request more txs even if you have them
There was a problem hiding this comment.
Yes, we can filter it on the blockchain-api side and even request the filtered data from the provider.
I created an issue reown-com/blockchain-api#540 to track it and ping you when it's ready.
| <wui-flex | ||
| flexDirection="column" | ||
| class="group-container" | ||
| last-group="${isLastGroup ? 'true' : 'false'}" |
There was a problem hiding this comment.
why use strings?
if neded, we can do String(isLastGroup)
Breaking Changes
Changes