-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auth): AppKit Auth #2413
Open
Cali93
wants to merge
96
commits into
main
Choose a base branch
from
feat/appkit-auth
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(auth): AppKit Auth #2413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Enes <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: Enes <[email protected]> Co-authored-by: Ben Kremer <[email protected]> Co-authored-by: Sven <[email protected]> Co-authored-by: Luka Isailovic <[email protected]>
enesozturk
reviewed
Jun 19, 2024
Co-authored-by: Enes <[email protected]> Co-authored-by: Ben Kremer <[email protected]> Co-authored-by: Sven <[email protected]> Co-authored-by: Luka Isailovic <[email protected]> Co-authored-by: Ignacio Santise <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Introduces AppKit Auth.
Notable changes:
chains
has been removed fromgetMessageParams
, we're relying on the chains provided to the connectorenableAuth: true
developers don't need to provide asiweConfig
. A default config is used instead.Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist