Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): AppKit Auth #2413

Open
wants to merge 96 commits into
base: main
Choose a base branch
from
Open

feat(auth): AppKit Auth #2413

wants to merge 96 commits into from

Conversation

Cali93
Copy link
Collaborator

@Cali93 Cali93 commented Jun 13, 2024

Context

Introduces AppKit Auth.
Notable changes:

  • chains has been removed from getMessageParams, we're relying on the chains provided to the connector
  • By using enableAuth: true developers don't need to provide a siweConfig. A default config is used instead.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

vercel bot commented Jun 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-laboratory ✅ Ready (Inspect) Visit Preview Oct 17, 2024 1:41pm
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 1:41pm
web3modal-gallery ✅ Ready (Inspect) Visit Preview Oct 17, 2024 1:41pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Oct 17, 2024 1:41pm

Co-authored-by: Enes <[email protected]>
Co-authored-by: Ben Kremer <[email protected]>
Co-authored-by: Sven <[email protected]>
Co-authored-by: Luka Isailovic <[email protected]>
apps/laboratory/src/pages/library/wagmi-siwe.tsx Outdated Show resolved Hide resolved
packages/common/src/utils/ConstantsUtil.ts Outdated Show resolved Hide resolved
packages/core/src/controllers/ApiController.ts Outdated Show resolved Hide resolved
packages/core/src/controllers/ApiController.ts Outdated Show resolved Hide resolved
packages/scaffold/src/client.ts Outdated Show resolved Hide resolved
packages/siwe/core/utils/AppKitAuthUtil.ts Outdated Show resolved Hide resolved
Co-authored-by: Enes <[email protected]>
Co-authored-by: Ben Kremer <[email protected]>
Co-authored-by: Sven <[email protected]>
Co-authored-by: Luka Isailovic <[email protected]>
Co-authored-by: Ignacio Santise <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants