Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

:fix proxied socialWindow state issue #2490

Merged
merged 10 commits into from
Jul 3, 2024
Merged

:fix proxied socialWindow state issue #2490

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9b1fbe5
Merge branch 'main' of github.com:WalletConnect/web3modal
svenvoskamp Jun 12, 2024
d75ce27
Merge branch 'main' of github.com:WalletConnect/web3modal
svenvoskamp Jun 13, 2024
fece97c
Merge branch 'main' of github.com:WalletConnect/web3modal
svenvoskamp Jun 14, 2024
7017b50
Merge branch 'main' of github.com:WalletConnect/web3modal
svenvoskamp Jun 17, 2024
588b49c
Merge branch 'main' of github.com:WalletConnect/web3modal
svenvoskamp Jun 20, 2024
12d10c1
Merge branch 'main' of github.com:WalletConnect/web3modal
svenvoskamp Jun 21, 2024
1aa986b
Merge branch 'main' of github.com:WalletConnect/web3modal
svenvoskamp Jul 1, 2024
a2fcb33
Merge branch 'main' of github.com:WalletConnect/web3modal
svenvoskamp Jul 2, 2024
af73ec3
fix socialWindow issue
svenvoskamp Jul 2, 2024
5bded99
Merge branch 'main' into fix/socialwindow
enesozturk Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/core/src/controllers/AccountController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import type { W3mFrameTypes } from '@web3modal/wallet'
import { ChainController } from './ChainController.js'
import type { Chain } from '@web3modal/common'
import { NetworkController } from './NetworkController.js'
import { proxy } from 'valtio'
import { proxy, ref } from 'valtio'

// -- Types --------------------------------------------- //
export interface AccountControllerState {
Expand Down Expand Up @@ -141,7 +141,7 @@ export const AccountController = {

setSocialWindow(socialWindow: AccountControllerState['socialWindow'], chain?: Chain) {
if (socialWindow) {
ChainController.setAccountProp('socialWindow', socialWindow, chain)
ChainController.setAccountProp('socialWindow', ref(socialWindow), chain)
}
},

Expand Down
Loading