Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: SA Tests switch network before flow #2529

Merged
merged 5 commits into from
Jul 11, 2024
Merged

chore: SA Tests switch network before flow #2529

merged 5 commits into from
Jul 11, 2024

Conversation

tomiir
Copy link
Collaborator

@tomiir tomiir commented Jul 10, 2024 •
edited
Loading

Description

  • Simplify flows by switching to supported Network (Sepolia) first
  • Unify signature and signature validation tests

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections

@vercel Vercel
Copy link

vercel bot commented Jul 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Jul 10, 2024 10:52pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Jul 10, 2024 10:52pm

@enesozturk enesozturk merged commit 1a81fc1 into main Jul 11, 2024
9 checks passed
@enesozturk enesozturk deleted the chore/smart-account-tests-improvement branch July 11, 2024 13:57
This was referenced Jul 17, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enesozturk enesozturk enesozturk approved these changes

@lukaisailovic lukaisailovic lukaisailovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomiir @enesozturk @lukaisailovic