Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove intermediate select screen account on auth connector #2827

Merged
merged 10 commits into from
Oct 30, 2024

Conversation

tomiir
Copy link
Collaborator

@tomiir tomiir commented Sep 9, 2024

Description

  • Removes intermediate select account screen on auth connector multi-address

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections

Copy link

vercel bot commented Sep 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-laboratory ✅ Ready (Inspect) Visit Preview Oct 30, 2024 11:17am
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 11:17am
web3modal-gallery ✅ Ready (Inspect) Visit Preview Oct 30, 2024 11:17am
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Oct 30, 2024 11:17am

Copy link
Contributor

github-actions bot commented Sep 9, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 346.16% 4440 / 18484
🔵 Statements 346.16% 4440 / 18484
🔵 Functions 371.17% 367 / 1078
🔵 Branches 466.63000000000005% 673 / 1374
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/core/src/controllers/RouterController.ts 56.79% 100% 62.5% 56.79% 115-116, 123, 125-127, 129, 131-133, 135-137, 144-145, 147, 149-150, 152-160, 199-206
packages/scaffold-ui/exports/index.ts 0% 0% 0% 0% 1, 9-14, 17-64, 67-117
packages/scaffold-ui/src/modal/w3m-router/index.ts 0% 0% 0% 0% 1, 9-11, 14, 16, 18, 20, 23, 25, 27-30, 32-47, 49-52, 55-57, 59, 62-169, 171-172, 174-178, 180-181, 183-186, 188-191
packages/scaffold-ui/src/partials/w3m-header/index.ts 0% 0% 0% 0% 1, 20, 23-29, 31-89, 91-93, 96, 99, 101, 103, 105, 107, 109, 111, 113, 115, 117-131, 133-135, 138-141, 144, 149-152, 154-158, 160-168, 170-171, 173-175, 177, 180, 183, 185, 187-188, 190-192, 194, 196, 198, 202, 204-205, 207, 209, 215, 217, 220, 222-228, 230, 232-233, 236-238, 240, 242-243, 246-247, 249, 251-252, 255, 257, 259-264, 266-269, 271-272, 274-277, 279-280, 282-283, 285-291, 293-294, 296-322, 324-327
packages/scaffold-ui/src/views/w3m-connecting-wc-view/index.ts 0% 0% 0% 0% 1, 17-18, 20, 22, 24, 27, 29, 31, 33-41, 43-45, 48-51, 53-55, 57, 60-61, 66-67, 69-91, 93-94, 96-101, 103-111, 113-116, 118-119, 121-123, 125-133, 136-150, 152-153, 155-163, 166-168, 171-176, 178-179, 181-183, 185, 187-188, 192, 194-210
packages/scaffold-ui/src/views/w3m-email-verify-otp-view/index.ts 0% 0% 0% 0% 1, 12-13, 15-19, 21-28, 30-43, 45-51
packages/scaffold-ui/src/views/w3m-profile-view/index.ts 0% 0% 0% 0% 1, 18-20, 23, 26, 28, 30, 32, 34-55, 57-59, 62-65, 67-68, 71-73, 79-91, 97, 107, 111, 114, 117-119, 123, 126, 128-133, 135-137, 139-143, 148, 150, 152, 154-167
Generated in workflow #7031 for commit 7e70bc9 by the Vitest Coverage Report Action

Copy link
Contributor

github-actions bot commented Sep 9, 2024

♻️ Vite-Size ♻️

Size Difference

Size (kb) Gzip (kb)
Total Diff. 0 0

Current Size

Name Size (kb) Gzip (kb)
assets/index-CueFzxuG.js 1865.21 532.825
assets/index.js 9.63 3.159
assets/index2.js 11.572 3.199
assets/w3m-modal.js 7.371 2.601
assets/noble-curves.js 31.941 12.778
assets/2.21.4_bufferutil.js 2.789 1.327
assets/index3.js 102.251 29.116
assets/index4.js 304.393 87.286
assets/hooks.module.js 74.443 25.59
index.html 0.329 0.235
Total Size 2409.929 698.116

Base Size

Name Size (kb) Gzip (kb)
assets/index-CueFzxuG.js 1865.21 532.825
assets/index.js 9.63 3.159
assets/index2.js 11.572 3.199
assets/w3m-modal.js 7.371 2.601
assets/noble-curves.js 31.941 12.778
assets/2.21.4_bufferutil.js 2.789 1.327
assets/index3.js 102.251 29.116
assets/index4.js 304.393 87.286
assets/hooks.module.js 74.443 25.59
index.html 0.329 0.235
Total Size 2409.929 698.116

Copy link

changeset-bot bot commented Sep 19, 2024

🦋 Changeset detected

Latest commit: 7e70bc9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@reown/appkit-scaffold-ui Patch
@reown/appkit Patch
@reown/appkit-core Patch
@apps/demo Patch
@apps/gallery Patch
@apps/laboratory Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-polkadot Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-common Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-siwe Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch
@reown/appkit-siwx Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants