Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding base sepolia support for wagmi permission tests #2851

Closed
wants to merge 12 commits into from
Closed

adding base sepolia support for wagmi permission tests #2851

wants to merge 12 commits into from

Conversation

KannuSingh
Copy link
Collaborator

@KannuSingh KannuSingh commented Sep 14, 2024 •
edited
Loading

Description

  • Enable ERC7715 permissions test on baseSepolia
  • Enabled signing and sending the userOp using the granted permissions via WalletService/UserOpBuilder service [previously it was also calling co-signer service]

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections

@vercel Vercel
Copy link

vercel bot commented Sep 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
appkit-laboratory ✅ Ready (Inspect) Visit Preview Sep 24, 2024 0:26am
web3modal-gallery ✅ Ready (Inspect) Visit Preview Sep 24, 2024 0:26am
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Sep 24, 2024 0:26am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 14, 2024 •
edited
Loading

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 241.46000000000004% 4148 / 10391
🔵 Statements 241.46000000000004% 4148 / 10391
🔵 Functions 270.67% 321 / 801
🔵 Branches 312.08% 571 / 1045
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/appkit/src/tests/mocks/UniversalProvider.ts 100% 100% 100% 100%
packages/appkit/src/universal-adapter/client.ts 61.77% 53.22% 53.12% 61.77% 107-108, 143-144, 147, 155-157, 166-169, 171-173, 175-177, 179-181, 183-188, 190, 192-201, 203, 205-208, 210-215, 217, 219, 221-224, 237-239, 248-250, 252-254, 256-259, 261-262, 288-289, 307-312, 316-321, 331, 333-336, 342-350, 352, 354-355, 372-373, 375-380, 409, 418-419, 455-458, 460, 462-464, 467-470, 474-475, 477-486, 488-489, 491-494, 532-536, 541-544, 561-562, 574-576, 578-593
packages/appkit/src/utils/HelpersUtil.ts 100% 100% 100% 100%
Generated in workflow #6279

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 14, 2024 •
edited
Loading

♻️ Vite-Size ♻️

Size Difference

Size (kb) Gzip (kb)
Total Diff. 0.157 0.065

Current Size

Name Size (kb) Gzip (kb)
assets/index-rtYWu7Y-.js 1866.92 532.919
assets/index.js 9.63 3.16
assets/index2.js 11.572 3.198
assets/w3m-modal.js 7.397 2.615
assets/noble-curves.js 31.941 12.778
assets/2.21.4_bufferutil.js 2.789 1.326
assets/index3.js 102.251 29.116
assets/index4.js 304.393 87.286
assets/hooks.module.js 74.286 25.525
index.html 0.329 0.235
Total Size 2411.508 698.158

Base Size

Name Size (kb) Gzip (kb)
assets/index-rtYWu7Y-.js 1866.92 532.919
assets/index.js 9.63 3.16
assets/index2.js 11.572 3.198
assets/w3m-modal.js 7.397 2.615
assets/noble-curves.js 31.941 12.778
assets/2.21.4_bufferutil.js 2.789 1.326
assets/index3.js 102.251 29.116
assets/index4.js 304.393 87.286
assets/hooks.module.js 74.443 25.59
index.html 0.329 0.235
Total Size 2411.665 698.223

@KannuSingh KannuSingh changed the title [WIP} adding base sepolia support for wagmi permission tests adding base sepolia support for wagmi permission tests Sep 17, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 17, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: c847065

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@KannuSingh KannuSingh marked this pull request as ready for review September 17, 2024 18:55
lukaisailovic
lukaisailovic approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@lukaisailovic lukaisailovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work with both sepolia and base-sepolia?

@KannuSingh
Copy link
Collaborator Author

Yes, I deployed the Donut contract using Create2 so it will be using the same address.

@lukaisailovic
Copy link
Collaborator

@KannuSingh Should we merge this or?

@KannuSingh
Copy link
Collaborator Author

PR supersedes this one, so we can go ahead and close it.

@KannuSingh KannuSingh closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaisailovic lukaisailovic lukaisailovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KannuSingh @lukaisailovic