Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:chore replace secure site sdk url with reown reown secure site #2860

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

svenvoskamp
Copy link
Contributor

Description

Replace old walletconnect secure site sdk url to reown secure site sdk

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

vercel bot commented Sep 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Sep 19, 2024 7:39am
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Sep 19, 2024 7:39am

Copy link

changeset-bot bot commented Sep 17, 2024

🦋 Changeset detected

Latest commit: e1cf163

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@reown/appkit-wallet Patch
@apps/demo Patch
@apps/gallery Patch
@apps/laboratory Patch
@examples/html-ethers Patch
@examples/html-ethers5 Patch
@examples/html-wagmi Patch
@examples/next-ethers Patch
@examples/next-wagmi Patch
@examples/react-ethers Patch
@examples/react-ethers5 Patch
@examples/react-solana Patch
@examples/react-wagmi Patch
@examples/vue-ethers5 Patch
@examples/vue-solana Patch
@examples/vue-wagmi Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-polkadot Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@reown/appkit-ethers Patch
@reown/appkit-ethers5 Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-solana Patch
@reown/appkit-ui Patch
@reown/appkit-wagmi Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svenvoskamp svenvoskamp changed the title add reown secure site :chore replace secure site sdk url with reown reown secure site Sep 17, 2024
Copy link
Contributor

github-actions bot commented Sep 17, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 241.68% 4167 / 10438
🔵 Statements 241.68% 4167 / 10438
🔵 Functions 268.27000000000004% 320 / 802
🔵 Branches 307.78% 568 / 1040
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/core/src/utils/ConstantsUtil.ts 100% 100% 100% 100%
Generated in workflow #6145

Copy link
Contributor

github-actions bot commented Sep 17, 2024

♻️ Vite-Size ♻️

Size Difference

Size (kb) Gzip (kb)
Total Diff. 0 0

Current Size

Name Size (kb) Gzip (kb)
assets/index-D3plvB2r.js 1870.163 533.749
assets/index.js 9.63 3.16
assets/index2.js 11.572 3.198
assets/w3m-modal.js 7.371 2.6
assets/noble-curves.js 31.941 12.777
assets/2.21.4_bufferutil.js 2.789 1.33
assets/index3.js 102.251 29.115
assets/index4.js 304.393 87.285
assets/hooks.module.js 74.443 25.589
index.html 0.329 0.236
Total Size 2414.882 699.039

Base Size

Name Size (kb) Gzip (kb)
assets/index-D3plvB2r.js 1870.163 533.749
assets/index.js 9.63 3.16
assets/index2.js 11.572 3.198
assets/w3m-modal.js 7.371 2.6
assets/noble-curves.js 31.941 12.777
assets/2.21.4_bufferutil.js 2.789 1.33
assets/index3.js 102.251 29.115
assets/index4.js 304.393 87.285
assets/hooks.module.js 74.443 25.589
index.html 0.329 0.236
Total Size 2414.882 699.039

@ignaciosantise
Copy link
Collaborator

@svenvoskamp there are some other files that contain secure.walletconnect url

@lukaisailovic
Copy link
Collaborator

lukaisailovic commented Oct 3, 2024

@svenvoskamp @tomiir Lets pause the work on this one for now. I think we should close it for the time being

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants