[DO NOT MERGE] fix: deeplink not working after connection #2882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Coverage Report for Coverage
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
♻️ Vite-Size ♻️Size Difference
Current Size
Base Size
|
magiziz
force-pushed
the
fix/walletconnect-deeplink-failure
branch
from
dc64e29
to
83e48eb
Compare
magiziz
commented
Sep 20, 2024
Comment on lines
+417
to
+429
| if (this.appKit?.getCaipAddress() && !this.appKit?.getIsConnectedState()) { | ||
| this.appKit?.setIsConnected(true, this.appKit?.getActiveChainNamespace() || 'eip155') | ||
| } |
There was a problem hiding this comment.
I wish i could put this logic in a handler, but we're syncing account before listening to our handlers.
I tried to refactor it so it's the other way around, but that introduces more issues.
magiziz
force-pushed
the
fix/walletconnect-deeplink-failure
branch
from
8738ceb
to
83e48eb
Compare
magiziz
changed the title
|
Seems like something that got merged in main broke this PR |
magiziz
force-pushed
the
fix/walletconnect-deeplink-failure
branch
2 times, most recently
from
8738ceb
to
83e48eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After connecting with a wallet on mobile deeplinks will fail when trying to sign a message or tx.
This is happening because this.appkit.getIsConnectedState() is always
false. We never update it which causeswcLinkingto reset and always beundefinedType of change
Associated Issues
For Linear issues: Closes APKT-1133
Checklist