Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update siwx session typing with message and data #3208

Merged
merged 4 commits into from
Nov 7, 2024

Conversation

zoruka
Copy link
Contributor

@zoruka zoruka commented Nov 6, 2024

Description

Refactor SIWXSession adding data and moving message to string data.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@zoruka zoruka requested a review from tomiir November 6, 2024 19:05
Copy link

changeset-bot bot commented Nov 6, 2024

⚠️ No Changeset found

Latest commit: b55a50d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 0:49am
appkit-vue-solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 0:49am
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 0:49am
vue-wagmi-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 0:49am
web3modal-gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 0:49am

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 341.12% 4507 / 18757
🔵 Statements 341.12% 4507 / 18757
🔵 Functions 376.16999999999996% 372 / 1088
🔵 Branches 465.18000000000006% 683 / 1392
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/core/src/controllers/ConnectionController.ts 41.26% 61.11% 26.92% 41.26% 82-86, 93-94, 100-130, 154-156, 159-175, 178-179, 182-183, 186-187, 190-191, 194-195, 198-199, 202-203, 206-207, 210-211, 214-215, 232-233, 236-238, 241-242, 245-246, 249-250, 257-263, 269-270, 284-290, 295-296, 301-330
packages/core/src/utils/SIWXUtil.ts 100% 100% 100% 100%
packages/siwx/src/core/SIWXConfig.ts 17.64% 100% 0% 17.64% 17-20, 23-24, 27-33, 36-44, 47-65, 68-69, 72-78
packages/siwx/src/core/SIWXMessenger.ts 100% 91.66% 100% 100%
packages/siwx/src/core/SIWXVerifier.ts 100% 100% 100% 100%
packages/siwx/src/messengers/InformalMessenger.ts 100% 100% 100% 100%
packages/siwx/src/storages/LocalStorage.ts 80.55% 83.33% 85.71% 80.55% 13-18, 43-44
packages/siwx/src/verifiers/EIP155Verifier.ts 100% 100% 100% 100%
packages/siwx/src/verifiers/SolanaVerifier.ts 86.66% 66.66% 100% 86.66% 20-21
Generated in workflow #7251 for commit b55a50d by the Vitest Coverage Report Action

@zoruka zoruka merged commit b57579b into main Nov 7, 2024
19 checks passed
@zoruka zoruka deleted the refactor/siwx-types branch November 7, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants