feat(balance): adding forced balance update by the contract address #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekbrother
commented
May 14, 2024
| ]"#, | ||
| ); | ||
|
|
||
| let provider = Provider::<Http>::try_from(format!( |
There was a problem hiding this comment.
This will be refactored in a followup to use the SelfProvider and direct rpc calls, like in #649
nopestack
approved these changes
May 15, 2024
chris13524
reviewed
May 15, 2024
chris13524
reviewed
May 15, 2024
geekbrother
force-pushed
the
feat/invalidating_balance_cache
branch
from
965d110
to
45bf830
Compare
chris13524
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a forced balance update for a certain token by passing the ERC-20 token contract address.
According to the SPEC the optional
forceUpdateargument can be passed to the/balanceendpoint with the list of token contract addresses (CAIP-10) to force the balance update by invoking the RPC call to the contract and overriding the balance response from Zerion for certain tokens contract addresses.This improvement is useful to live update the balance at the UI when making token swaps or on-ramp payments by bypassing Zerion's cached balances.
How Has This Been Tested?
Due Diligence