feat(terraform): IRN VPC Peering #682
Conversation
terraform/res_network.tf
Outdated
| @@ -38,6 +38,22 @@ module "vpc" { | |||
| vpc_flow_log_tags = module.this.tags | |||
| } | |||
|
|
|||
| resource "aws_vpc_peering_connection" "irn" { | |||
| count = var.irn_vpc_id != null ? 1 : 0 | |||
There was a problem hiding this comment.
I think this should be required not optional?
There was a problem hiding this comment.
Don't know, I made it optional for relay, because it may not be needed for all envs.
@geekbrother do we need it always here?
There was a problem hiding this comment.
Don't know, I made it optional for relay, because it may not be needed for all envs. @geekbrother do we need it always here?
Since sessions will be a part of the blockchain-api and no plans to run it in a cloud without it, I believe we can make this required.
Fortunately, fits fine. |
There was a problem hiding this comment.
Thanks! Looks good to me. Can't test this now, but adding the test to connect to the IRN to #681 so we will be sure that works.
Description
Adds VPC peering to the IRN VPC
How Has This Been Tested?
Manually
Due Diligence