-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CoSigner): implementing contract-call
and native-token-transfer
permissions check
#809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekbrother
changed the title
feat: implementing contract call check
feat(CoSigner): implementing Oct 11, 2024
contract-call
and native-token-transfer
permissions check
geekbrother
force-pushed
the
fix/co_signer_fixes
branch
2 times, most recently
from
October 11, 2024 22:25
d218df8
to
df4af03
Compare
nopestack
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1st pass, looks good though some tests so we can verify what it does would be appreciated
chris13524
reviewed
Oct 14, 2024
chris13524
reviewed
Oct 14, 2024
chris13524
reviewed
Oct 14, 2024
chris13524
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
geekbrother
force-pushed
the
fix/co_signer_fixes
branch
from
October 15, 2024 23:11
df4af03
to
c065870
Compare
geekbrother
force-pushed
the
fix/co_signer_fixes
branch
from
October 15, 2024 23:14
c065870
to
a3afd4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the draft testing implementation for the following permissions check during the CoSign process:
contract-call
permission:Extracting the contract call address from the bundler's execution operation and comparing it to the permissions allowed for the address call.
native-token-transfer
permission:Extracted values from the bundler's execution batch are summarized and checked with the allowance.
Currently missing:
How Has This Been Tested?
Due Diligence