Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): fixing integration tests context url path #815

Merged
merged 1 commit into from
Oct 19, 2024
Merged

Conversation

geekbrother
Copy link
Contributor

@geekbrother geekbrother commented Oct 19, 2024

Description

This PR fixing the bug in CI tests introduced since #804 where changing the server address type to URL.
When format! the URL path with the Url type the host address results in the ending slash / that adds a double slash // as a result and 404 error in CI tests.
This PR removes the starting slash in format!.

How Has This Been Tested?

Tested by running CI tests locally.

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@geekbrother geekbrother self-assigned this Oct 19, 2024
@geekbrother geekbrother marked this pull request as ready for review October 19, 2024 11:13
@geekbrother geekbrother merged commit e18f53f into master Oct 19, 2024
10 checks passed
@geekbrother geekbrother deleted the fix/ci_tests branch October 19, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants