Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CA): fixing the topup amount and status check #822

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

geekbrother
Copy link
Contributor

@geekbrother geekbrother commented Oct 31, 2024

Description

This PR fixes the following issues in the Chain Orchestrator:

  • Calculating the exact topup amount (current destination chain balance - expected transfer amount) instead of just using the transfer amount, in this case, the remaining balance will be used for the transfer;
  • Fixing the status check endpoint by adding the right (destination) contract and chain ID instead of the bridging data;
  • Checking the ERC20 token destination balance amount to skip bridging if it's sufficient.

How Has This Been Tested?

  • Integration tests for the chain orchestration were updated to catch this case.

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@geekbrother geekbrother self-assigned this Oct 31, 2024
@geekbrother geekbrother marked this pull request as ready for review October 31, 2024 14:52
@geekbrother geekbrother merged commit 8fa4e0e into master Oct 31, 2024
15 checks passed
@geekbrother geekbrother deleted the fix/ca_erc20_check branch October 31, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants