Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add friend fast delete feature #85

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

o3LL
Copy link

@o3LL o3LL commented Nov 13, 2020

Hi, I was trying to get used to the project by adding some feature that was a nice-to-have.
Since it's working well, I through it should be nice to open this PR!

Feature
I added an "x" cross to delete players directly from the friend-list.

Capture d’écran 2020-11-13 à 20 04 34

What I probably missed:

  • I don't have many friends, this feature may need to be tested with a huge friend-list since it use infinite scroll loading.
  • I didn't added any tests, I don't know about this project test requirement. If needed I should be able to add some.
  • Page loading, this feature may not work in modal since I don't know how to open one 😨
  • That's my first try with React inside a browser extension, I may have used anti-pattern or anything else, help welcomed 👍

What I also added:

  • I updated fetch wrapper to be able to add the request method as an argument, this shouldn't have any impact on other request using the wrapper.

@timche timche force-pushed the main branch 4 times, most recently from c494fbf to 0353163 Compare January 25, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant