Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #53: Task 7 (Trial 3): Remove performance analysis components from regression analysis view #56

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 2 additions & 50 deletions src/components/RegressionMockup.tsx
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
import { PerformanceAnalysisResult } from "../performance/interfaceTypes";
import { RecordingDisplay } from "./performance/RecordingDisplay";
import { OriginDisplay } from "./performance/OriginDisplay";
import { RegressionOriginDisplay } from "./regression/RegressionOriginDisplay";
import { useEffect, useState } from "react";
import { fetchPerformanceResult } from "@/performance/performanceResult";
import { getRecordingId } from "@/performance/params";
import { assert } from "@/performance/utils";
import { WorkspaceData, fetchWorkspaceData, getMainBranchRecordings, getRecordingData } from "@/performance/workspaceData";
import { NetworkDataComparison, TimingComparison } from "./performance/PerformanceComparison";

export default function RegressionMockup() {
const [result, setResult] = useState<PerformanceAnalysisResult | string | null>(null);
Expand Down Expand Up @@ -57,8 +56,6 @@ export default function RegressionMockup() {

const { recordingURL, summaries } = analysisResult;

const mainBranchSummaries = mainBranchResults.map(r => r.analysisResult?.summaries || []).flat();

return (
<div className="App h-screen w-screen flex flex-col text-xl">
<h1 className="text-5xl self-center">Regression Analysis</h1>
Expand All @@ -82,54 +79,9 @@ export default function RegressionMockup() {
</div>
<div className="m-4 overflow-y-auto">
{summaries.map((summary, index) => {
const mainBranchTimings = mainBranchSummaries
.filter(s => s.origin.kind === summary.origin.kind)
.map(s => ({
total: s.elapsed,
network: s.networkTime,
scheduling: s.schedulingTime,
mainThread: s.mainThreadTime,
workerThread: s.workerThreadTime,
timer: s.timerTime,
unknown: s.unknownTime
}));

const mainBranchNetworkData = mainBranchSummaries
.filter(s => s.origin.kind === summary.origin.kind)
.map(s => s.networkDataByExtension || {});

return (
<div key={index} className="mb-8 p-4 border rounded-lg">
<OriginDisplay summary={summary} />

{summary.commitScreenShot && (
<div className="mt-4">
<h4 className="font-semibold">Final Screenshot:</h4>
<img
src={summary.commitScreenShot.screen}
alt="Final state"
className="max-w-full h-auto mt-2 border"
/>
</div>
)}

<TimingComparison
timing={{
total: summary.elapsed,
network: summary.networkTime,
scheduling: summary.schedulingTime,
mainThread: summary.mainThreadTime,
workerThread: summary.workerThreadTime,
timer: summary.timerTime,
unknown: summary.unknownTime
}}
mainBranchTimings={mainBranchTimings}
/>

<NetworkDataComparison
data={summary.networkDataByExtension || {}}
mainBranchData={mainBranchNetworkData}
/>
<RegressionOriginDisplay summary={summary} />
</div>
);
})}
Expand Down
18 changes: 18 additions & 0 deletions src/components/regression/RegressionOriginDisplay.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import { OriginSummary } from "../../performance/interfaceTypes";
import { OriginSummaryDisplay } from "../performance/OriginSummaryDisplay";

// Displays only the origin summary for regression analysis, without performance-specific sections

interface RegressionOriginDisplayProps {
summary: OriginSummary;
}

export function RegressionOriginDisplay(props: RegressionOriginDisplayProps) {
const { summary } = props;

return (
<div className="m-2 gap-4 px-4 py-2 bg-slate-800 hover:bg-slate-700 text-white rounded-lg">
<OriginSummaryDisplay summary={summary}></OriginSummaryDisplay>
</div>
);
}
Loading