Fix the retry logic in the editLogPoint test helper (#10533)

replayio · May 16, 2024 · 32cc456 · 32cc456
1 parent aeea3bd
commit 32cc456
Showing 1 changed file with 15 additions and 18 deletions.
diff --git a/packages/e2e-tests/helpers/source-panel.ts b/packages/e2e-tests/helpers/source-panel.ts
@@ -337,24 +337,21 @@ export async function editLogPoint(
     // The typeahead popup sometimes sticks around and overlaps the save button.
     // Sometimes, it will show up after we check the first time (PRO-238) so we
     // retry a couple times to ensure that we can clear it and move forward.
-    await waitFor(
-      async () => {
-        await hideTypeAheadSuggestions(page, {
-          sourceLineNumber: lineNumber,
-          type: "log-point-condition",
-        });
-        await hideTypeAheadSuggestions(page, {
-          sourceLineNumber: lineNumber,
-          type: "log-point-content",
-        });
-
-        const saveButton = line.locator('[data-test-name="PointPanel-SaveButton"]');
-        await expect(saveButton).toBeEnabled();
-        await saveButton.click();
-        await saveButton.waitFor({ state: "detached" });
-      },
-      { timeout: 2_000 }
-    );
+    await waitFor(async () => {
+      await hideTypeAheadSuggestions(page, {
+        sourceLineNumber: lineNumber,
+        type: "log-point-condition",
+      });
+      await hideTypeAheadSuggestions(page, {
+        sourceLineNumber: lineNumber,
+        type: "log-point-content",
+      });
+
+      const saveButton = line.locator('[data-test-name="PointPanel-SaveButton"]');
+      await expect(saveButton).toBeEnabled();
+      await saveButton.click({ timeout: 1_000 });
+      await saveButton.waitFor({ state: "detached" });
+    });
   }
 }