Handle lack of point.frame (#10586)

replayio · Jun 26, 2024 · b1e1a4c · b1e1a4c
1 parent d7dc141
commit b1e1a4c
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 12 deletions.
diff --git a/src/ui/components/ProtocolViewer/suspense/recordedProtocolMessagesCache.ts b/src/ui/components/ProtocolViewer/suspense/recordedProtocolMessagesCache.ts
@@ -86,10 +86,9 @@ export const recordedProtocolMessagesCache = createFocusIntervalCacheForExecutio
           return [];
         }
 
-        const preferredLocation = getPreferredLocation(
-          sourcesState,
-          pointDescriptions[0].frame ?? []
-        );
+        const preferredLocation =
+          pointDescriptions[0].frame &&
+          getPreferredLocation(sourcesState, pointDescriptions[0].frame);
 
         if (!preferredLocation) {
           return [];

diff --git a/src/ui/suspense/frameCache.ts b/src/ui/suspense/frameCache.ts
@@ -88,7 +88,7 @@ export interface FormattedPointStackFrame {
   url?: string;
   source: Source;
   functionLocation: Location;
-  executionLocation: Location;
+  executionLocation?: Location;
   point?: PointDescription;
   functionDetails?: FormattedEventListener;
 }
@@ -123,7 +123,8 @@ export const formattedPointStackCache: Cache<
     const formattedFrames = pointStack.map(frame => {
       updateMappedLocationForPointStackFrame(sourcesById, frame);
       const functionLocation = getPreferredLocation(sourcesById, [], frame.functionLocation);
-      const executionLocation = getPreferredLocation(sourcesById, [], frame.point?.frame ?? []);
+      const executionLocation =
+        frame.point?.frame && getPreferredLocation(sourcesById, [], frame.point.frame);
 
       const source = sourcesById.get(functionLocation.sourceId)!;
 
@@ -210,11 +211,13 @@ export const relevantAppFrameCache: Cache<
         resultPoint = relevantAppCodeFrame.point;
       }
 
-      const formattedFunction = await formatFunctionDetailsFromLocation(
-        replayClient,
-        "unknown",
-        relevantAppCodeFrame.executionLocation
-      );
+      const formattedFunction =
+        relevantAppCodeFrame.executionLocation &&
+        (await formatFunctionDetailsFromLocation(
+          replayClient,
+          "unknown",
+          relevantAppCodeFrame.executionLocation
+        ));
 
       functionName = formattedFunction?.functionName;
     }

diff --git a/src/ui/suspense/jumpToLocationCache.ts b/src/ui/suspense/jumpToLocationCache.ts
@@ -82,6 +82,9 @@ export const reduxStoreDetailsCache = createSingleEntryCache<
 function isFrameInDecl(functions: FunctionBoundaries[], frame: FormattedPointStackFrame) {
   // Check to see if the frame is inside any of the listed function definitions
   return functions.some(decl => {
+    if (!frame.executionLocation) {
+      return false;
+    }
     return (
       frame.executionLocation.line >= decl.location.begin.line &&
       frame.executionLocation.line < decl.location.end.line &&
@@ -148,7 +151,13 @@ export function findFunctionParent(functions: FunctionOutline[], fnIndex: number
   return null;
 }
 
-async function isReduxMiddleware(replayClient: ReplayClientInterface, location: Location) {
+async function isReduxMiddleware(
+  replayClient: ReplayClientInterface,
+  location: Location | undefined
+) {
+  if (!location) {
+    return false;
+  }
   const sourceOutline = await sourceOutlineCache.readAsync(replayClient, location.sourceId);
   const dispatchFn = findFunctionOutlineForLocation(location, sourceOutline);
   const functions = sourceOutline.functions;