Skip to content

Commit

Permalink
Switch meta e2e tests from breakpoints-02 to logpoints-01 (#10603)
Browse files Browse the repository at this point in the history
  • Loading branch information
bvaughn authored Jul 8, 2024
1 parent 925db84 commit b9563de
Show file tree
Hide file tree
Showing 7 changed files with 13 additions and 18 deletions.
2 changes: 1 addition & 1 deletion packages/e2e-tests/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ You'll also probably need to specifically share that recording as "Public", espe

We use 1 specific Playwright test recording which is a replay of the breakpoints-05 test from this repo. Similar to the instructions above, to update this to a more recent version, you can visit the dashboard for FE E2E Tests and select a more recent recording ID for that test.

We also now have a "golden recording" of one of our own `breakpoints-02` E2E test runs. This serves as a testbed for checking more advanced behaviors like the React and Redux routines. If we ever need to update this, just copy-paste the recording ID from a test run in our "Frontend E2E tests" workspace.
We also now have a "golden recording" of one of our own `logpoints-01` E2E test runs. This serves as a testbed for checking more advanced behaviors like the React and Redux routines. If we ever need to update this, just copy-paste the recording ID from a test run in our "Frontend E2E tests" workspace.

### Test Suite Dashboard Tests

Expand Down
4 changes: 2 additions & 2 deletions packages/e2e-tests/examples.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 3 additions & 4 deletions packages/e2e-tests/tests/jump-to-code-02_redux-j2c.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ import { closeSource, verifyJumpToCodeResults } from "../helpers/source-panel";
import { getByTestName, waitFor } from "../helpers/utils";
import test from "../testFixture";

// trunk-ignore(gitleaks/generic-api-key)
test.use({ exampleKey: "breakpoints-02" });
test.use({ exampleKey: "logpoints-01" });

async function checkForJumpButton(actionListItem: Locator, shouldBeEnabled: boolean) {
const jumpButton = getEventJumpButton(actionListItem);
Expand Down Expand Up @@ -90,8 +89,8 @@ test(`jump-to-code-02: Redux J2C functionality`, async ({
await closeSource(page, "SourcesTree.tsx");

// Inside of an adapter that passes dispatch-wrapped actions to <QuickOpenModal>
// This is also one tick off, but should still _display_ as "1/3"
// This is also one tick off, but should still _display_ as "1/10"
jumpToReduxDispatch(page, "quickOpen/setQuickOpenQuery");
await verifyJumpToCodeResults(page, "QuickOpenModal.tsx", 551, { current: 1, total: 3 });
await verifyJumpToCodeResults(page, "QuickOpenModal.tsx", 551, { current: 1, total: 10 });
await closeSource(page, "QuickOpenModal.tsx");
});
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@ import test from "../testFixture";
const sourceUrl = "react-dom.production.js";
const lineNumber = 150;

// trunk-ignore(gitleaks/generic-api-key)
test.use({ exampleKey: "breakpoints-02" });
test.use({ exampleKey: "logpoints-01" });

test(`logpoints-10: too-many-points-to-find UX`, async ({
pageWithMeta: { page, recordingId, testScope },
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,11 @@ import { getFocusBeginTime, getFocusEndTime, setFocusRange } from "../helpers/ti
import test, { expect } from "../testFixture";

// We need 500...10k hits
// Line 301 has 534 hits
// Line 12196 has 4.4k hits
const sourceUrl = "react-dom.production.js";
const lineNumber = 301;
const lineNumber = 12196;

// trunk-ignore(gitleaks/generic-api-key)
test.use({ exampleKey: "breakpoints-02" });
test.use({ exampleKey: "logpoints-01" });

test(`logpoints-11: too-many-points-to-run-analysis UX`, async ({
pageWithMeta: { page, recordingId, testScope },
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@ import { getSelectedLineNumber, waitForSelectedSource } from "../helpers/source-
import { debugPrint, waitFor } from "../helpers/utils";
import test, { expect } from "../testFixture";

// Why is this even getting confused as an API key?
// trunk-ignore(gitleaks/generic-api-key)
test.use({ exampleKey: "breakpoints-02" });
test.use({ exampleKey: "logpoints-01" });

test("react_devtools-02: RDT integrations (Chromium)", async ({
pageWithMeta: { page, recordingId, testScope },
Expand All @@ -32,7 +30,7 @@ test("react_devtools-02: RDT integrations (Chromium)", async ({

await openDevToolsTab(page);

await warpToMessage(page, "Waiting for breakpoint at doc_rr_basic.html:21 (waitForBreakpoint)");
await warpToMessage(page, "Waiting for breakpoint at doc_rr_basic.html:20 (waitForBreakpoint)");

// If the "React" tab shows up, we know that the routine ran
await openReactDevtoolsPanel(page);
Expand Down
2 changes: 1 addition & 1 deletion test/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Tests are defined in the `manifest.js` file.
// Example browser based e2e tests
{
"example": "doc_rr_basic.html",
"script": "breakpoints-02.js",
"script": "logpoints-01.js",
"targets": ["gecko", "chromium"]
},

Expand Down

0 comments on commit b9563de

Please sign in to comment.