Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI "Upload strategies" page to mention new advanced upload options #210

Merged
merged 3 commits into from
Jul 5, 2024
Merged

Update CI "Upload strategies" page to mention new advanced upload options #210

merged 3 commits into from
Jul 5, 2024

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Jun 23, 2024 •
edited
Loading

Note that we shouldn't merge this until PRO-692 is complete.

Our test reporter docs suggest using a legacy, soon-to-be-removed filter option for advanced configurations. Instead we should be using the new advanced upload options released in PRO-549. This PR updates that page to reference the new settings.

@vercel Vercel
Copy link

vercel bot commented Jun 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
replay-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2024 3:15pm

@replay-io replay.io
Copy link

replay-io bot commented Jun 23, 2024 •
edited
Loading

Status Complete ↗︎
Commit 840d2d2
Results
✅ 5 Passed
  • home page redirects to quickstart guide
  • navigation collapsing works
  • navigation expanding works
  • player zoom in
  • table of contents redirects to proper item

    • @bvaughn
    Copy link
    Contributor Author

    bvaughn commented Jul 3, 2024

    Ugh. Either I have the worst PR->CI luck or this repo just sucks to commit code to.

    @bvaughn bvaughn marked this pull request as ready for review July 5, 2024 14:51
    @bvaughn bvaughn merged commit 59bbe22 into main Jul 5, 2024
    8 checks passed
    @bvaughn bvaughn deleted the PRO-583 branch July 5, 2024 15:22
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @Andarist Andarist Andarist approved these changes

    @jasonLaster jasonLaster Awaiting requested review from jasonLaster

    @filiphric filiphric Awaiting requested review from filiphric

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @bvaughn @Andarist