-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ENV NVIDIA_DRIVER_CAPABILITIES=all to permit Video SDK transcoding, 3D rendering, and X11 OpenGL Display #1288
Add ENV NVIDIA_DRIVER_CAPABILITIES=all to permit Video SDK transcoding, 3D rendering, and X11 OpenGL Display #1288
Conversation
a2f586a
to
3d3d238
Compare
Hmm works locally on my WSL2 machine but not on replicate.com itself. Will need to continue investigating. |
May have shot myself in foot. Will revisit sometime in the future. |
https://replicate.com/p/jokv5fbbljv3mu64k4eyyyqjli Nope, got it working after all. Pretty pleased 😄 . I would like to bring this up for re-consideration. |
3d3d238
to
e5f9947
Compare
Could there be some consideration of this? It is not possible to set this at runtime and get the same results as the Nvidia parts of the runtime will mount more files into the container if it sees these environment variables set. That is not something possible when the container is already running. |
Hi @nelsonjchen sorry your PR went unnoticed. This seems like a sensible change to me, but do you have a sense of whether this change might break anything? Wold you be willing to update this PR with docs about the purpose of this env var in https://github.com/replicate/cog/blob/main/docs/environment.md ? |
My sense is that it does not, but I am also not a typical/normal/daily GPU user. However, I do defer to this comment by an Nvidia employee in the thread I linked on Nvidia's repo about this which was made about 3 years ago with a general approval for this kind of change: NVIDIA/nvidia-container-runtime#112 (comment)
I don't know. It's not really configurable which is unprecedented. The environment variables there are usually customizable. I suppose I could add a section of "interesting" environmental variables that can't be configured but might be of interest. |
66bf240
to
a875807
Compare
@zeke Documented. Not sure if that's what you're looking for. |
a875807
to
9d9d39b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good to me, and the documentation is clear and helpful. 👍🏼
That said, I would like to get a second opinion from folks who have more expertise on the matter and can speak to possible issues that could arise from enabling this.
Maybe this can be more palatable as an option? |
Hey @nelsonjchen sorry there hasn't been much attention on this. I think it'd be much less risky to ship this as an option than a new default. 👍🏼 |
OK, I'll see what I can do to propose it as an option. |
I think I'm fine with this even without it being an option. Can you rebase on main please? |
Signed-off-by: Nelson Chen <[email protected]>
9d9d39b
to
5e4ea6e
Compare
Signed-off-by: Nelson Chen <[email protected]>
5e4ea6e
to
dbac30b
Compare
Rebased on main. |
…g, 3D rendering, and X11 OpenGL Display (replicate#1288) * Add ENV NVIDIA_DRIVER_CAPABILITIES=all * Document NVIDIA_DRIVER_CAPABILITIES Signed-off-by: Nelson Chen <[email protected]>
NVIDIA/nvidia-container-runtime#112
I'm interested in capabilities beyond the default Nvidia base images of just compute and utility. I'm particularly interested in using the video encoding and decoding functionality and OpenGL in an X11 application.