Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cog predict: check output path writability before predict/train #1389

Merged
merged 6 commits into from
Jul 17, 2024

Conversation

yorickvP
Copy link
Contributor

cog train failed after 30 minutes with "weights: is a directory".
I refactored predictIndividualInputs so it checks output file writability if the path is known.

@yorickvP yorickvP force-pushed the yorickvp/predict-check-first branch from a22ed38 to 68ae4a6 Compare November 20, 2023 17:01
@yorickvP yorickvP requested a review from mattt February 8, 2024 16:07
@mattt mattt force-pushed the yorickvp/predict-check-first branch from 68ae4a6 to 45f2f23 Compare July 17, 2024 11:52
Copy link
Contributor

@mattt mattt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @yorickvP! Sorry to keep you waiting. Rally glad to make this quality of life improvement.

@mattt mattt merged commit c95733b into main Jul 17, 2024
11 checks passed
@mattt mattt deleted the yorickvp/predict-check-first branch July 17, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants