-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a cog integration test for apt-packages #2104
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
8W9aG
commented
Jan 8, 2025
- Ensure that apt-packages are installed in the main docker image file
- Previously they were installed in a separate stage and not copied over
aron
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, just wanted to clarify the setup.
test-integration/test_integration/fixtures/apt-packages/cog.yaml
Outdated
Show resolved
Hide resolved
* Ensure that apt-packages are installed in the main docker image file * Previously they were installed in a separate stage and not copied over
8W9aG
force-pushed
the
add-cog-int-test-apt-packages
branch
from
January 9, 2025 14:47
7b79594
to
9e3af97
Compare
* Make clean was not removing dependencies installed by tox
erbridge
reviewed
Jan 13, 2025
Co-authored-by: F <[email protected]> Signed-off-by: Will Sackfield <[email protected]>
Co-authored-by: F <[email protected]> Signed-off-by: Will Sackfield <[email protected]>
Co-authored-by: F <[email protected]> Signed-off-by: Will Sackfield <[email protected]>
Co-authored-by: F <[email protected]> Signed-off-by: Will Sackfield <[email protected]>
Co-authored-by: F <[email protected]> Signed-off-by: Will Sackfield <[email protected]>
erbridge
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.