Add fast pusher for fast builds #2114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
8W9aG
commented
Jan 17, 2025
8W9aG
commented
- Separates push into standard and fast
- Generates the necessary tar files to push
- Calls the backend to create a file to push
* Separates push into standard and fast * Generates the necessary tar files to push * Calls the backend to create a file to push
* When building/pushing make sure we remove redundant tar files we have created previously.
* Allow mocking of docker exec commands
meatballhat
approved these changes
Jan 22, 2025
| } | ||
|
|
||
| func loadAuthFromConfig(conf *configfile.ConfigFile, registryHost string) (string, error) { | ||
| return conf.AuthConfigs[registryHost].Password, nil |
There was a problem hiding this comment.
Is it OK that this will panic if the key doesn't exist?
There was a problem hiding this comment.
Yeh I would rather the program had a hard termination as this is unexpected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.