Handle any ModelError raised by replicate
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeke
reviewed
Sep 19, 2022
| image = model.predict(prompt=prompt)[0] | ||
| except replicate.exceptions.ModelError as ex: | ||
| if "NSFW" in str(ex): # model output was classified as NSFW | ||
| await msg.edit(content="> NSFW detected. Please try again.") |
There was a problem hiding this comment.
Maybe we should also include the original prompt in this message, so people know which one(s) failed, in case multiple simultaneous predictions are in flight.
zeke
reviewed
Sep 19, 2022
zeke
reviewed
Sep 19, 2022
| image = model.predict(prompt=prompt)[0] | ||
| except replicate.exceptions.ModelError as ex: | ||
| if "NSFW" in str(ex): # model output was classified as NSFW | ||
| await msg.edit(content="> NSFW detected. Please try again.") |
There was a problem hiding this comment.
Suggested change
| await msg.edit(content="> NSFW detected. Please try again.") | |
| await msg.edit(content="“{prompt}”\n> NSFW detected. Please try again.") |
zeke
reviewed
Sep 19, 2022
| await msg.edit(content="> NSFW detected. Please try again.") | ||
| else: # something else went wrong, log to console so developer can debug | ||
| print(ex) | ||
| await msg.edit(content="> Error. Please try again.") |
There was a problem hiding this comment.
Suggested change
| await msg.edit(content="> Error. Please try again.") | |
| await msg.edit(content="“{prompt}”\n> Error. Please try again.") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zeke Have been using this code a for a custom bot actually. Super handy for testing models. I notice we don't handle any errors raised by the replicate package. This presently happens when we flag an NSFW output, but can happen for other reasons too.
It's unfortunately not nearly as clean - and tutorial code should probably be clean and simple. Any ideas?