Adds a secret skip preflight environment variable #2364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TL;DR ----- Supports the `SKIP_HOST_PREFLIGHTS` environment variable to skip the preflight checks. Thjis is not documented and not for general use. Details ------- Offers a "hidden" way to skip preflight checks by setting the environment variable `SKIP_HOST_PREFLIGHTS`. I'm adding the flag to support our Instruqt labs, since the Instruqt environment require a wildcard DNS entry that causes the host preflights to fail. I decided on this approach to avoid teaching any bad habits by telling the user to use `--ignore-host-preflights` when teaching them about the Embedded Cluster. I wanted instead to avoid the checks on their behalf without them realized it. This variable is not deliberately not documented to avoid similar encouragement of bad habits.
crdant
force-pushed
the
feature/crdant/adds-secret-preflight-skip
branch
from
187d6e1 to
884305b
Compare
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
|
FYI, @ajp-io, this is for the labs workaround we discussed. |
|
I'm curious @sgalsaleh and @emosbaugh, are the failing tests predictable? I don't have any variations that would seem to impact those areas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Supports the
SKIP_HOST_PREFLIGHTSenvironment variable to skip the preflight checks. This is not documented and not for general use.Details
Offers a "hidden" way to skip preflight checks by setting the environment variable
SKIP_HOST_PREFLIGHTS. I'm adding the flag to support our Instruqt labs, since the Instruqt environment require a wildcard DNS entry that causes the host preflights to fail.I decided on this approach to avoid teaching any bad habits by telling the user to use
--ignore-host-preflightswhen teaching them about the Embedded Cluster. I wanted instead to avoid the checks on their behalf without them realized it. This variable is not deliberately not documented to avoid similar encouragement of bad habits.