Add CMX Update Network outbound behind feature flag #506

jdewinne · 2025-01-31T17:52:50Z

When the Air Gap feature is not enabled:

❯ replicated network update outbound --id b649e7a6 --outbound none
Error: Air Gap is not enabled. Contact Replicated to get more information.

When the Air Gap feature is enabled:

❯ replicated network update outbound --id b649e7a6 --outbound none
ID          NAME                           STATUS          CREATED                           EXPIRES                           OUTBOUND
b649e7a6    lucid_cannon                   running         2025-01-31 09:43 PST              2025-01-31 10:43 PST              none

divolgin · 2025-01-31T23:00:13Z

cli/cmd/network_update_outbound.go

-		return errors.Wrap(err, "update network outbound")
+	}
+	if err != nil {
+		return err


why no wrap?

add feature flag

b3643c1

jdewinne added the type::feature label Jan 31, 2025

squizzi previously approved these changes Jan 31, 2025

View reviewed changes

divolgin reviewed Jan 31, 2025

View reviewed changes

feedback

17084a6

jdewinne dismissed squizzi’s stale review via 17084a6 February 1, 2025 00:11

divolgin approved these changes Feb 1, 2025

View reviewed changes

jdewinne merged commit ea83702 into main Feb 1, 2025
5 checks passed

jdewinne deleted the joshd/sc-119518/put-airgap-behind-an-cmx-air-gap-feature branch February 1, 2025 00:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add CMX Update Network outbound behind feature flag #506

Add CMX Update Network outbound behind feature flag #506

jdewinne commented Jan 31, 2025 •

edited

Loading

divolgin Jan 31, 2025

Add CMX Update Network outbound behind feature flag #506

Add CMX Update Network outbound behind feature flag #506

Conversation

jdewinne commented Jan 31, 2025 • edited Loading

divolgin Jan 31, 2025

Choose a reason for hiding this comment

jdewinne commented Jan 31, 2025 •

edited

Loading