Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix readonly #158

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Fix readonly #158

merged 3 commits into from
Jan 11, 2024

Conversation

nightwing
Copy link
Collaborator

fixes #157

sergeichestakov
sergeichestakov approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@sergeichestakov sergeichestakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet, thanks for the fix! 📖

src/cm_adapter.ts Outdated Show resolved Hide resolved
@nightwing @sergeichestakov
remove stray console.log
96346cb 
Co-authored-by: Sergei Chestakov <[email protected]>
@nightwing nightwing merged commit ff439cb into master Jan 11, 2024
1 check passed
@nightwing nightwing deleted the fix-readonly branch January 11, 2024 18:57
Opisek pushed a commit to Opisek/codemirror-vim that referenced this pull request Jan 22, 2024
@nightwing @sergeichestakov @Opisek
Fix readonly (replit#158)
c183bcc 
* tweak test runner in web-demo.html

* fix readonly mode

* remove stray console.log

Co-authored-by: Sergei Chestakov <[email protected]>

---------

Co-authored-by: Sergei Chestakov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeichestakov sergeichestakov sergeichestakov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

readonly not work on vim mode
2 participants
@nightwing @sergeichestakov